Skip to content

models/feature: Add iteration limit warning #9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

models/feature: Add iteration limit warning #9580

merged 1 commit into from
Oct 4, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
@Turbo87 Turbo87 mentioned this pull request Oct 4, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (828f52e) to head (fdc20ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/models/feature.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9580      +/-   ##
==========================================
- Coverage   89.10%   89.09%   -0.01%     
==========================================
  Files         289      289              
  Lines       29057    29060       +3     
==========================================
+ Hits        25890    25892       +2     
- Misses       3167     3168       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit b692905 into rust-lang:main Oct 4, 2024
10 checks passed
@Turbo87 Turbo87 deleted the iter-limit-warning branch October 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth3lbert eth3lbert eth3lbert approved these changes

Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @eth3lbert